Remove special hostname behavior for aws cloud-provider #7212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7212 +/- ##
==========================================
+ Coverage 23.38% 23.70% +0.31%
==========================================
Files 33 33
Lines 3438 3392 -46
==========================================
Hits 804 804
+ Misses 2587 2541 -46
Partials 47 47
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
dereknola
approved these changes
Nov 6, 2024
The in-tree aws cloud provider has been removed and the kubelet will fail to start if the cloud-provider-name is set to aws, so this is dead code. Signed-off-by: Brad Davidson <[email protected]>
brandond
force-pushed
the
remove-aws-hostname
branch
2 times, most recently
from
403c567 to
f9daf8a
Compare
VestigeJ
approved these changes
Nov 6, 2024
ShylajaDevadiga
approved these changes
Nov 6, 2024
This was referenced Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Remove special hostname behavior for aws cloud-provider
The in-tree aws cloud provider has been removed and the kubelet will fail to start if the cloud-provider-name is set to aws, so this is dead code.
Types of Changes
tech debt
Verification
None, this code is unused.
Testing
Linked Issues
awscloud-provider helpers functions #6626User-Facing Change
Further Comments